Skip to content

1 - Issue #93 Merged encoders from Lib into SDK #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

1 - Issue #93 Merged encoders from Lib into SDK #168

merged 1 commit into from
Jun 14, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jun 11, 2019

Merged encoders from Lib into SDK

Dragon Milestone / 2: https://github.com/nemtech/nem2-sdk-typescript-javascript/milestone/2

Issue #93

@rg911
Added symbol#93
aff8179 
Merged encoders from Lib into SDK
@rg911 rg911 added this to the Dragon milestone Jun 11, 2019
@rg911 rg911 requested a review from evias June 11, 2019 18:46
@coveralls
Copy link

coveralls commented Jun 11, 2019

Pull Request Test Coverage Report for Build 452

  • 315 of 329 (95.74%) changed or added relevant lines in 24 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 81.003%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/format/RawUInt64.ts 33 34 97.06%
src/core/format/Convert.ts 57 63 90.48%
src/core/format/RawAddress.ts 37 44 84.09%
Totals Coverage Status
Change from base Build 442: 2.2%
Covered Lines: 1983
Relevant Lines: 2335
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 452

  • 315 of 329 (95.74%) changed or added relevant lines in 24 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 81.003%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/format/RawUInt64.ts 33 34 97.06%
src/core/format/Convert.ts 57 63 90.48%
src/core/format/RawAddress.ts 37 44 84.09%
Totals Coverage Status
Change from base Build 442: 2.2%
Covered Lines: 1983
Relevant Lines: 2335
💛 - Coveralls

This was referenced Jun 12, 2019
Merged
Merged
@rg911 rg911 removed this from the Dragon milestone Jun 12, 2019
@rg911 rg911 mentioned this pull request Jun 12, 2019
Merged
@rg911 rg911 changed the title Issue #93 Merged encoders from Lib into SDK 1 - Issue #93 Merged encoders from Lib into SDK Jun 12, 2019
@rg911 rg911 deleted the task/g93_merge_encoders branch July 8, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias